Repository navigation
Safety net: CI, one column conversion, readable types, doctest test - #21
Merged
Merged
Conversation
The docstring detection for call boxes sliced a line by an ast byte offset, and the condition comments of the → chain decoded byte offsets themselves. Both now use _glpython_text_before, which _glpython_ui_column builds on, so every offset into a line goes through one place. The regression test covers a docstring and a condition on lines with ä and 🙂. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
type(a) != list stepped to <class 'int'> != list; it now steps to int != list, in substitutions and in the copied → chain alike, as the course's evaluator is traced on paper. The program's own output keeps Python's repr. test:runtime runs the new scripts/check-runtime-values.py too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
One job on every push and pull request: npm ci, lint, the embed build, test:protocol and test:runtime (CPython 3.12, Pyodide's version). What needs Pyodide in a browser isn't checked; a notice in the run says so. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
scripts/check-runtime-doctests.py runs src/runtime/doctests.py as the Tests button does: the summary, failing examples with doctest's report and the want/got texts for «Erhalten · Erwartet», exceptions, the print hint, the __main__ guard, umlauts and 🙂, imports of another project file, files without examples, files that don't load, and the restored display hook. test:runtime (and so CI) runs it too, ahead of the German hints that will extend doctests.py. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Package 1 «Absichern»: a safety net before new features. The only visible change is the type display (item 3).
Changes
.github/workflows/ci.yml): one job on every push and PR.npm ci(with npm cache), lint, the embed build,test:protocol,test:runtime.input(), gturtle) and the UI._glpython_text_beforegives the text in front of an offset;_glpython_ui_columnbuilds on it. The docstring detection of the call boxes and the condition comments of the → chain no longer handle bytes themselves. The regression test now also covers a docstring and a condition on lines with ä and 🙂.type(a) != listnow steps toint != listinstead of<class 'int'> != list, in the visualizer and in the copied → chain. Output fromprintand the REPL keeps Python's repr. New test:scripts/check-runtime-values.py.scripts/check-runtime-doctests.py), ahead of package 2, which will extenddoctests.py. It covers:__main__guard;test:runtimeruns all three runtime scripts. Each new test fails when its code is broken on purpose: a byte slice in the condition comment; the type display before this PR; a disabled print hint; a changed want text.Follow-ups (low priority, not changed here)
t = type(x)) isn't replaced by its value.🤖 Generated with Claude Code